fix(a11y): label account QR code button#60616
Conversation
Will-thom
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
code looks good, thank you
susnux
requested review from
pringelmann and
szaimen
and removed request for
sorbaugh
|
/compile amend / |
|
Your commit is missing the DCO |
Will-thom
force-pushed
the
issue-60292-a11y-header-buttons
branch
from
7c3cdc0 to
3e65513
Compare
AndyScherzinger
force-pushed
the
issue-60292-a11y-header-buttons
branch
from
3e65513 to
587fc62
Compare
|
/compile |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
AndyScherzinger
force-pushed
the
issue-60292-a11y-header-buttons
branch
from
587fc62 to
746dc6c
Compare
|
/compile |
Signed-off-by: Francisco Silva <116388885+Will-thom@users.noreply.github.com>
Signed-off-by: Will-thom <116388885+Will-thom@users.noreply.github.com>
Will-thom
force-pushed
the
issue-60292-a11y-header-buttons
branch
from
3a6368e to
685ce73
Compare
Signed-off-by: Will-thom <116388885+Will-thom@users.noreply.github.com>
5 participants
Summary
Fixes #60292
Tests
npx vitest run --project nextcloud-ui-legacy core/src/tests/components/AccountMenuProfileEntry.spec.ts core/src/tests/components/AppMenu.spec.tsnpm run lintgit diff --check origin/master...HEADValidated in a clean Docker container from a fresh
nextcloud/serverclone usingnode:24-bookworm.